|Subject:||Re: [PATCH] On the nasty "ghost key" problem on NS|
|Date:||Thu, 10 Nov 2022 19:59:38 +0800|
Thanks for the pointer, this indeed turned out unnecessary (and dangerous).
A tester informed me of a problem in the v3 patch:
safe_call (0, Qns_in_echo_area)
is incorrect. The 0 should be 1, or nargs will be -1 for funcall_general.
This will cause an error to be signaled, which explains why
`waiting_for_input` has to be masked.
[ I guess we could add an assertion that numargs >= 0 in funcall_general or
somewhere else? ]
This patch should be correct even without the ugly `waiting_for_input` hack.
I’ve been running patched Emacs for some time without issues.
With the current understanding of the bug, I guess the comment line could be
/* Protect against throw-on-input. */
Description: Binary data
|[Prev in Thread]||Current Thread||[Next in Thread]|