[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Utilize new font-lock faces for C/C++ and Python tree-sitter

From: Theodor Thornhill
Subject: Re: [PATCH] Utilize new font-lock faces for C/C++ and Python tree-sitter use
Date: Mon, 14 Nov 2022 20:20:53 +0100

(adding back in emacs-devel)

Randy Taylor <dev@rjt.dev> writes:

> Hey guys,
> Seems like the mailing lists are down from what I can tell, so just
> sending the patch I sent out yesterday in case either of you wanted to
> take a look. Not sure how long the lists will be down for (or even
> what's going on).
> BTW I think it would be a good idea to figure out some guidelines for
> the tree-sitter features (and write them down somewhere) - some that
> are applicable to as many languages as possible, and preferably as
> small as possible. That way we can have consistent implementations,
> and languages can deviate where they may need to. I will think about
> composing a list of what we may want.

I think that's smart, but I envision we will diverge in any case, hehe.

> Here's what I said in the email:
> I'm just submitting C/C++ and Python for now since some of the other files are
> a little more volatile currently (there are some patches in progress).

I like it!

Are you sure we cover most of the stuff that was covered in the old
style?  I see it is different visually, but that's likely the new faces
are without any color, right?

I think you should add similar changes to all the new modes:

- ts-mode
- json-ts-mode
- css-ts-mode
- java-ts-mode
- js-mode

If you have time and energy, of course :-)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]