[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: * lisp/progmodes/eglot.el (eglot--connect): Use project-name

From: João Távora
Subject: Re: * lisp/progmodes/eglot.el (eglot--connect): Use project-name
Date: Thu, 24 Nov 2022 14:43:57 +0000


In this commit:

commit 1f39da3098a2a4cec9985e6db934ed14b7b522b7
Author: Stephen Leake <stephen_leake@stephe-leake.org>
Date:   Tue Nov 22 11:43:22 2022 -0800

    * lisp/progmodes/eglot.el (eglot--connect): Use project-name
    As discussed in bug#48747.

You use an fboundp check for the project-name function recently
added to project.el.

This is not necessary in eglot.el, since it already depends on the
project.el :core ELPA package.  eglot.el is itself such a package.
So you must merely bump the "Version:" of the project.el package in 
that file and then make eglot.el reference the new version in its

Of course you should/could ask permission before bumping 
project.el's version (or not, depends on Dmitry's policy) 

This way we can avoid those pesky checks. I'll change the commit
to use package-name directly now.


PS: When about to apply a patch to eglot.el, even one where I
have already approved the underlying idea, I would appreciate
it if you could just shoot me a personal mail showing the full 
contents of the patch.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]