[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Merging use-package before Emacs 29, hopefully

From: Eli Zaretskii
Subject: Re: Merging use-package before Emacs 29, hopefully
Date: Thu, 24 Nov 2022 17:12:19 +0200

> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Thu, 24 Nov 2022 05:19:25 -0800
> Cc: John Wiegley <johnw@gnu.org>, Eli Zaretskii <eliz@gnu.org>, Payas Relekar 
> <relekarpayas@gmail.com>
> I have pushed the current progress on merging use-package to the new
> branch scratch/use-package.  I based this on João Távora's and Payas
> Relekar's work on merging eglot, but adapted it for use-package.[1]

Thanks for working on this.

> 1. I'm still working on the new use-package.texi manual.  It pretty much
>    amounts to a rewrite, or close to it.  If Eli and John are fine with
>    it, I'm happy to finish up that work after the merge.  Otherwise, I'm
>    not sure I can make it in time for the Emacs 29 merge window.  I'll
>    try my best in any case, of course, but other commitments destroyed
>    most of my time for focused work in the last week.

It's okay to keep working on the manual after the branch point, yes.

> 2. I didn't mark trivial commits with "Copyright-paperwork-exempt: yes".
>    Using the scripts from João and Payas, it will be trivial to add, if
>    I can get access to a list of the relevant commits.
>    - Do we care strongly about this?

Yes, we do.

>    - If yes, do we have a list of commits that need such marking?  Or,
>      equivalently, the authors whose work we don't need assignments for?

I hope John can answer that.  Truth be told, this should have been taken
care of before pushing the scratch branch to the Emacs repository.

> 3. The mailmap.txt file may or may not need looking over.  For example,
>    I'm not sure how important it is that the emails line up with the
>    copyright assignments file.

It is pretty important, so if there are significant discrepancies, we'd need
that incorporated.

> 5. I added the files README.md as admin/USE-PACKAGE.README and NEWS.md
>    as etc/USE-PACKAGE-NEWS.  We might want to just skip these files
>    though, as they don't add much.  They are available in the old
>    repository if anyone should need to take a look at them.

Why do we need the README?  Ideally, it should be incorporated into the
manual, and then discarded.

As for USE-PACKAGE.NEWS, unless we are going to keep updating it, I would
omit it as well.  If you "git rm" it, it will be in Git history if someone
needs it.

Alternatively, leave that file as NEWS.OLD under lisp/use-package/.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]