emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: scratch/backend-completion 9a62da21c2 1/2: Integrate Stefan suggesti


From: Eli Zaretskii
Subject: Re: scratch/backend-completion 9a62da21c2 1/2: Integrate Stefan suggestions but rename it to "external-completion.el"
Date: Wed, 07 Dec 2022 15:56:09 +0200

> From: João Távora <joaotavora@gmail.com>
> Date: Wed, 7 Dec 2022 11:09:02 +0000
> Cc: emacs-devel <emacs-devel@gnu.org>
> 
> Eli, if you haven't been following this discussion closely, this is a 
> refactor of 
> functionality already present in Eglot that consolidates the support for
> offering completions coming from external tools (like LSP servers, but not 
> only)
> and makes it available to more third party packages.
> 
> I think there shouldn't be any adverse effects of pushing this to the emacs-29
> branch, but if you think it's better, I'll push it to master instead.
> 
> It shouldn't make much of a difference since the new external-completion.el
> file is going to be a GNU ELPA :core package and as such it will be available
> in Emacs 28 anyway via package-install.
> 
> Let me know what you think.  The commentary of the new file, the docstring
> of external-completion-table and the commit messages should give details.
> I'll be happy to fix them further if you have comments.

I'm fine with installing this on the emacs-29 branch, but I think
external-completion.el warrants a NEWS entry.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]