[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master 2de25accaf 4/4: Warn about `condition-case' with quoted condi
From: |
Stefan Monnier |
Subject: |
Re: master 2de25accaf 4/4: Warn about `condition-case' with quoted condition names |
Date: |
Thu, 29 Dec 2022 11:14:50 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Mattias Engdegård [2022-12-29 16:50:37] wrote:
> 29 dec. 2022 kl. 16.33 skrev Stefan Monnier <monnier@iro.umontreal.ca>:
>>> But do we know all errors statically at compile-time?
>>
>> Error identifiers should have an `error-conditions` property.
>
> You left the `error-conditions` property check commented out in
> `byte-compile-condition-case` so maybe it wasn't quite that straightforward?
I can't remember what came up, but my guess is that it's a question
of making the byte-compiler recognize `define-error` and things like
that (i.e. try and reduce the number of false positives where the error
is unknown at compile time but will be known at run-time).
Stefan