Re: Changes OK for Emacs 29?

[Eli Zaretskii]

> From: Po Lu <luangruo@yahoo.com>
> Date: Fri, 20 Jan 2023 17:49:13 +0800
> 
> Users report that the following changes to two functions are needed for
> the Delete key to delete forward correctly on Haiku:
> 
> (defun display-symbol-keys-p (&optional display)
>   "Return non-nil if DISPLAY supports symbol names as keys.
> This means that, for example, DISPLAY can differentiate between
> the keybinding RET and [return]."
>   (let ((frame-type (framep-on-display display)))
>     (or (memq frame-type '(x w32 ns pc pgtk haiku))
>         ;; MS-DOS and MS-Windows terminals have built-in support for
>         ;; function (symbol) keys
>         (memq system-type '(ms-dos windows-nt)))))
> 
> (defun normal-erase-is-backspace-setup-frame (&optional frame)
>   "Set up `normal-erase-is-backspace-mode' on FRAME, if necessary."
>   (unless frame (setq frame (selected-frame)))
>   (with-selected-frame frame
>     (unless (terminal-parameter nil 'normal-erase-is-backspace)
>       (normal-erase-is-backspace-mode
>        (if (if (eq normal-erase-is-backspace 'maybe)
>                (and (not noninteractive)
>                     (or (memq system-type '(ms-dos windows-nt))
>                       (memq window-system '(w32 ns pgtk haiku))
>                         (and (eq window-system 'x)
>                              (fboundp 'x-backspace-delete-keys-p)
>                              (x-backspace-delete-keys-p))
>                         ;; If the terminal Emacs is running on has erase char
>                         ;; set to ^H, use the Backspace key for deleting
>                         ;; backward, and the Delete key for deleting forward.
>                         (and (null window-system)
>                              (eq tty-erase-char ?\^H))))
>              normal-erase-is-backspace)
>            1 0)))))
> 
> Are they ok for Emacs 29?

I don't know.  Please describe the problem, please show the changes
(as diffs, for example), and please explain how these changes fix the
problems.