emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fix display-buffer-use-some-window to honor reusable-frames


From: Eli Zaretskii
Subject: Re: [PATCH] Fix display-buffer-use-some-window to honor reusable-frames
Date: Wed, 01 Feb 2023 19:38:46 +0200

> Date: Wed, 1 Feb 2023 11:45:06 +0100
> Cc: tgbugs@gmail.com, emacs-devel@gnu.org, larsi@gnus.org
> From: martin rudalics <rudalics@gmx.at>
> 
> There's worse as I just noticed.  'display-buffer-avoid-small-windows':
> 
> - Invariably affects, once set, 'get-lru-window' which can be used
>    anywhere outside the scope of 'display-buffer'.  So it's not only a
>    misnomer but a typical example of a collateral effect.
> 
> - Is described in section 29.15.4 of the Elisp manual which talks about
>    "older options" some of them candidates for obsoletion.
> 
> - Ignores that an action alist entry of that type already existed.  It's
>    called 'window-min-height' and could have been easily used here.

Is this related to display-buffer-use-least-recent-window and/or
window-bump-use-time?  Or is this another set of issues?

Would it be possible to modify the effect of
display-buffer-avoid-small-windows so that it works via the
window-min-height alist entry?

> Just that any such option should never be used in 'get-lru-window' but
> exclusively in functions that pertain to 'display-buffer'.

I see.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]