RE: [External] : Re: [PATCH] Make rectangle-select able to skip lines(empty one, for example)

[Drew Adams]

below

 

> 1. Lose the *...* earmuffs.  Elisp doesn't embrace that CL convention for defvars.

 

I wonder, is it because Emacs had only dynamic binding? Maybe now the "*..*" can be helpful to distinguish dynamic vars from lexical. 

 

The question is for others. I'm just pointing out the current (and longstanding) convention (lack of that particular convention. (I'm guessing "that ship has sailed".)

> 2. The var's doc should say what it means by "skip".  Apparently it means (only) that function `apply-on-rectangle' doesn't apply its FUNCTION arg to empty lines.  I think it's important to say that the var affects (only) that function's behavior.

 

I think the application of FUNCTION is the main part of `apply-on-rectangle', so it is more or less obvious.

And you can easily see the effect in GUI, when using `rectangle-mark-mode' (C-x SPC).

 

I disagree that it's obvious what "skip" means.

 

I'm not quite sure how to name the var.

 

What it does:...

 

The description is good. Thx.