[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Finalizing 'inhibit-automatic-native-compilation'
From: |
Andrea Corallo |
Subject: |
Re: Finalizing 'inhibit-automatic-native-compilation' |
Date: |
Mon, 20 Feb 2023 09:03:34 +0000 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) |
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> Shouldn't make-temp-file-internal return a non predictable file name?
>
> Nope. It's less predictable but it's still predictable.
>
>> Otherwise what's the point of using make-temp-file in the first place if
>> the temporary name is predictable?
>
> `make-temp-name` uses `O_EXCL | O_CREAT` so as to close the race
> condition: if someone predicated the filename, we detect it atomically
> and we try again.
>
> You might like to check
>
>
> https://wiki.sei.cmu.edu/confluence/display/c/FIO21-C.+Do+not+create+temporary+files+in+shared+directories
Thanks for the pointer.
I'm still not really convinced we have a problem here with trampolines.
With `make-temp-file' we are really only choosing the filename and
suggesting it to libgccjit, this last one will perform the file
creation. I'd be surprised if GCC does not handle this correctly, and
in case shouldn't this be a GCC bug?
OTOH on a slightly differnt subject and in light of this, I think we
should probably backport e6043641d30 into emacs-30, so that eln files
are created onace and only by libgccjit. Eli WDYT?
Thanks
Andrea
- Re: Finalizing 'inhibit-automatic-native-compilation', (continued)
- Re: Finalizing 'inhibit-automatic-native-compilation', Eli Zaretskii, 2023/02/14
- Re: Finalizing 'inhibit-automatic-native-compilation', Andrea Corallo, 2023/02/14
- Re: Finalizing 'inhibit-automatic-native-compilation', Sean Whitton, 2023/02/14
- Re: Finalizing 'inhibit-automatic-native-compilation', Sean Whitton, 2023/02/16
- Re: Finalizing 'inhibit-automatic-native-compilation', Andrea Corallo, 2023/02/17
- Re: Finalizing 'inhibit-automatic-native-compilation', Sean Whitton, 2023/02/17
- Re: Finalizing 'inhibit-automatic-native-compilation', Eli Zaretskii, 2023/02/17
- Re: Finalizing 'inhibit-automatic-native-compilation', Tatsuya Kinoshita, 2023/02/18
- Re: Finalizing 'inhibit-automatic-native-compilation', Andrea Corallo, 2023/02/18
- Re: Finalizing 'inhibit-automatic-native-compilation', Stefan Monnier, 2023/02/18
- Re: Finalizing 'inhibit-automatic-native-compilation',
Andrea Corallo <=
- Re: Finalizing 'inhibit-automatic-native-compilation', Andrea Corallo, 2023/02/20
- Re: Finalizing 'inhibit-automatic-native-compilation', Eli Zaretskii, 2023/02/20
- Re: Finalizing 'inhibit-automatic-native-compilation', Eli Zaretskii, 2023/02/20
- Re: Finalizing 'inhibit-automatic-native-compilation', Andrea Corallo, 2023/02/20
- Re: Finalizing 'inhibit-automatic-native-compilation', Stefan Monnier, 2023/02/20
- Re: Finalizing 'inhibit-automatic-native-compilation', Andrea Corallo, 2023/02/20
- Re: Finalizing 'inhibit-automatic-native-compilation', Tatsuya Kinoshita, 2023/02/20
- Re: Finalizing 'inhibit-automatic-native-compilation', Andrea Corallo, 2023/02/21
- Re: Finalizing 'inhibit-automatic-native-compilation', Lynn Winebarger, 2023/02/20
- Re: Finalizing 'inhibit-automatic-native-compilation', Stefan Monnier, 2023/02/20