Re: Finalizing 'inhibit-automatic-native-compilation'

[Andrea Corallo]

Tatsuya Kinoshita <tats@debian.org> writes:

> On 2023-02-20 at 20:22 +0000, Andrea Corallo wrote:
>> I've installed 5d0b45cd67b on emacs-29 in order to use always
>> `make-temp-file'.
>
> Please be careful with the difference between make-temp-file-internal
> and make-temp-file.
>
>> +++ b/lisp/emacs-lisp/comp.el
>>              (expand-file-name
>> -             (make-temp-file-internal (file-name-sans-extension 
>> rel-filename)
>> -                                      0 ".eln" nil)
>> +             (make-temp-file (file-name-sans-extension rel-filename) 0 
>> ".eln"
>> +                             nil)
>>               temporary-file-directory))))
>
> This second argument of make-temp-file should be nil, and expanding
> against temporary-file-directory is already done by make-temp-file.
>
> Thanks,

Hi Tatsuya,

thanks for checking, 68df9e5953c fix that.

Bests

  Andrea