Re: server.el test failures

[Eli Zaretskii]

> Date: Tue, 28 Feb 2023 11:02:25 -0800
> Cc: eggert@cs.ucla.edu, emacs-devel@gnu.org
> From: Jim Porter <jporterbugs@gmail.com>
> 
> >      Eli> I don't think we should create GUI frames in batch, since the 
> > SIGIO
> >      Eli> handler is not set, and we generally aren't prepared for receiving
> >      Eli> it.  We should create a TTY frame instead, or maybe no frame at 
> > all.
> > 
> > I think the former would be better. Jim, since you wrote this test,
> > what do you think?
> 
> We should definitely create a frame in these tests, since that's what 
> the tests are trying to, well, test. (All the server tests are there to 
> make sure that the usual things you might do with "emacsclient" work 
> properly.)
> 
> This might be a real bug in Emacs: as Eli says, an Emacs server started 
> in batch mode shouldn't create GUI frames, but on the other hand, this 
> might be only be relevant to the regression tests (who starts an Emacs 
> server in a batch session?). I wouldn't mind just adding "-nw" to all 
> the "emacsclient -c" invocations in server-tests.el.

How about changing make-frame on master to create a TTY frame in batch
sessions, even if DISPLAY is set in the environment?