[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Merging feature/android
From: |
Eli Zaretskii |
Subject: |
Re: Merging feature/android |
Date: |
Thu, 09 Mar 2023 11:21:16 +0200 |
> From: Po Lu <luangruo@yahoo.com>
> Cc: eggert@cs.ucla.edu, arsen@aarsen.me, emacs-devel@gnu.org
> Date: Thu, 09 Mar 2023 16:07:04 +0800
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > I disagree with your conclusion, and I still think we should complain
> > noisily if modules cannot be supported.
>
> OK, but I still think this is a very bad idea. Do you object to
> rewriting emacs-module.c to not utilize __attribute__ ((cleanup))?
>
> What was said earlier by some people is wrong: as-is, in Emacs, it makes
> no difference whether or not we write:
>
> foo __attribute__ ((cleanup (module_reset_handlerlist)))...
>
> or:
>
> foo...
> module_reset_handlerlist (foo);
If you want to discuss this, please start a new thread and CC Daniel
Colascione and Philipp Stephani, who I believe wrote that part of
emacs-module.c. I don't think we should change that without a
thorough discussion, as that code is quite old and I don't think it
caused any trouble whatsoever.
- Re: Merging feature/android, (continued)
- Re: Merging feature/android, Paul Eggert, 2023/03/08
- Re: Merging feature/android, Po Lu, 2023/03/08
- Re: Merging feature/android, Paul Eggert, 2023/03/08
- Re: Merging feature/android, Po Lu, 2023/03/08
- Re: Merging feature/android, Po Lu, 2023/03/08
- Re: Merging feature/android, Eli Zaretskii, 2023/03/08
- Re: Merging feature/android, Eli Zaretskii, 2023/03/08
- Re: Merging feature/android, Po Lu, 2023/03/08
- Re: Merging feature/android, Eli Zaretskii, 2023/03/09
- Re: Merging feature/android, Po Lu, 2023/03/09
- Re: Merging feature/android,
Eli Zaretskii <=
- __attribute__ ((cleanup)) and emacs-module.c, Po Lu, 2023/03/09
- Re: __attribute__ ((cleanup)) and emacs-module.c, Philipp Stephani, 2023/03/09
- Re: __attribute__ ((cleanup)) and emacs-module.c, Po Lu, 2023/03/09
- Re: __attribute__ ((cleanup)) and emacs-module.c, Paul Eggert, 2023/03/10
- Re: __attribute__ ((cleanup)) and emacs-module.c, Po Lu, 2023/03/10
- Re: __attribute__ ((cleanup)) and emacs-module.c, Paul Eggert, 2023/03/11
- Re: __attribute__ ((cleanup)) and emacs-module.c, Po Lu, 2023/03/11
- Re: __attribute__ ((cleanup)) and emacs-module.c, Paul Eggert, 2023/03/11
- Re: Merging feature/android, Eli Zaretskii, 2023/03/08
- Re: Merging feature/android, Arsen Arsenović, 2023/03/06