[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Merging feature/android
From: |
Po Lu |
Subject: |
Re: Merging feature/android |
Date: |
Wed, 15 Mar 2023 08:16:26 +0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Robert Pluim <rpluim@gmail.com> writes:
>>>>>> On Tue, 14 Mar 2023 14:10:44 +0100, Robert Pluim <rpluim@gmail.com> said:
>
>>>>>> On Tue, 14 Mar 2023 19:34:48 +0800, Po Lu <luangruo@yahoo.com> said:
> Robert> Po Lu> Does this work too?
>
> Robert> Yes.
>
> And for the fileio-tests failure, I think youʼll need to revisit
> 84d27fe53b28
>
> If I undo part of that commit as follows, the test succeeds:
>
> diff --git a/src/fileio.c b/src/fileio.c
> index 99f710ccbf0..978e22f038c 100644
> --- a/src/fileio.c
> +++ b/src/fileio.c
> @@ -5004,7 +5004,7 @@ because (1) it preserves some marker positions (in
> unchanged portions
> /* Decode file format. Don't do this if Qformat_decode is not
> bound, which can happen when called early during loadup. */
>
> - if (inserted > 0 && !NILP (Fboundp (Qformat_decode)))
> + if (inserted > 0)
> {
> /* Don't run point motion or modification hooks when decoding. */
> specpdl_ref count1 = SPECPDL_INDEX ();
>
>
> Robert
Why isn't `format-decode' defined already when the test is run?
format-decode.el is indeed preloaded.
- Re: Merging feature/android, (continued)
Re: Merging feature/android, Po Lu, 2023/03/14
- Re: Merging feature/android, Robert Pluim, 2023/03/14
- Re: Merging feature/android, Po Lu, 2023/03/14
- Re: Merging feature/android, Robert Pluim, 2023/03/14
- Re: Merging feature/android, Robert Pluim, 2023/03/14
- Re: Merging feature/android, Po Lu, 2023/03/14
- Re: Merging feature/android, Robert Pluim, 2023/03/14
- Re: Merging feature/android, Robert Pluim, 2023/03/14
- Re: Merging feature/android,
Po Lu <=
- Re: Merging feature/android, Robert Pluim, 2023/03/15
- Re: Merging feature/android, Po Lu, 2023/03/15
- Re: Merging feature/android, Robert Pluim, 2023/03/15
- Re: Merging feature/android, Po Lu, 2023/03/15
- Re: Merging feature/android, Po Lu, 2023/03/15
- Re: Merging feature/android, Robert Pluim, 2023/03/17
- Re: Merging feature/android, Po Lu, 2023/03/17
- Re: Merging feature/android, Po Lu, 2023/03/20
- Re: Merging feature/android, Robert Pluim, 2023/03/20
- Re: Merging feature/android, Robert Pluim, 2023/03/20