emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 67ab357cdcc 7/7: Support treesit-thing-settings in search fun


From: Po Lu
Subject: Re: master 67ab357cdcc 7/7: Support treesit-thing-settings in search functions
Date: Sat, 15 Apr 2023 10:43:21 +0800
User-agent: Gnus/5.13 (Gnus v5.13)

Yuan Fu <casouri@gmail.com> writes:

> +/* Assq but doesn't signal.  */
> +static Lisp_Object
> +safe_assq (Lisp_Object key, Lisp_Object alist)
> +{
> +  Lisp_Object tail = alist;
> +  FOR_EACH_TAIL_SAFE (tail)
> +    if (CONSP (XCAR (tail)) && EQ (XCAR (XCAR (tail)), key))
> +      return XCAR (tail);
> +  return Qnil;
> +}

Please, write more descriptive doc strings.  I would write:

  /* Like `assq_no_quit', except it avoids chasing after circular
     lists.  */


reply via email to

[Prev in Thread] Current Thread [Next in Thread]