emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master d3ec68f5e43: ; Fix post-commit and pre-push hooks in worktree


From: Eli Zaretskii
Subject: Re: master d3ec68f5e43: ; Fix post-commit and pre-push hooks in worktrees again
Date: Fri, 05 May 2023 08:12:18 +0300

> Cc: Emacs developers <emacs-devel@gnu.org>
> Date: Fri, 05 May 2023 11:28:43 +0800
> From:  Ruijie Yu via "Emacs development discussions." <emacs-devel@gnu.org>
> 
> $ grep --line-number -e abs_ Makefile
> 192:abs_srcdir=/opt/src/emacs/base/emacs-30
> 266:buildlisppath=${abs_srcdir}/lisp
> 461:  @for dir in '$(abs_srcdir)' '$(lispdir)' '$(archlibdir)'; do \
> 497:  @(w32srcdir=`${srcdir}/build-aux/msys-to-w32 "${abs_srcdir}"`; \
> --8<---------------cut here---------------end--------------->8---
> 
> Notice that lines 461 and 497 protects against spaces (presumably),
> whereas line 266 doesn't.  If we do expect spaces in git root, line 266
> might be an issue.

Quoting of file names is needed in command lines, not in assignments
of values to Make variables.  Make doesn't have a problem with
variable values that include whitespace.  It's the shell that needs
quoting.

So line 266 cannot be the problem, but any command line that uses
$buildlisppath might be.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]