emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Reversed tmm-prompt items when tmm-mid-prompt is nil


From: Eli Zaretskii
Subject: Re: Reversed tmm-prompt items when tmm-mid-prompt is nil
Date: Mon, 29 May 2023 15:33:53 +0300

> From: Thiago Melo <tmdmelo@gmail.com>
> Date: Sun, 28 May 2023 14:59:37 +0000
> 
> Commit #5d844e1 fixed `tmm-prompt' for Emacs 29 (Bug#63754. Thanks,
> Eli!) and even made the `tmm-mid-prompt' = nil option work again.

AFAICT, this was broken ever since Emacs 22.1, when someone
"optimized" a regexp without paying attention to the possibility of
tmm-mid-prompt being nil.

> The fix also surfaced one inconsistency between nil and non-nil
> `tmm-mid-prompt'.  When nil, the items shown by `tmm-prompt' are
> reversed.
> 
> Compare these two cases:
> 
> 
> (let ((tmm-mid-prompt "==>")
>       (test-menu '("top" ("menu" ("foo" . 1) ("bar" . 2) ("baz" . 3)))))
>   (tmm-prompt test-menu))
> 
> (let ((tmm-mid-prompt nil)
>       (test-menu '("top" ("menu" ("foo" . 1) ("bar" . 2) ("baz" . 3)))))
>   (tmm-prompt test-menu))
> 
> 
> It seems innocuous and not worth a bug report.  Still, here's a way to
> make this behavior more consistent:

Thanks, I installed a somewhat simpler version of this on the emacs-29
branch.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]