Re: master f17bdee79b1: sgml-mode.el: Cosmetic fixes

[Robert Pluim]

>>>>> On Mon, 17 Jul 2023 08:57:03 -0400, Stefan Monnier 
>>>>> <monnier@iro.umontreal.ca> said:

    Stefan> diff --git a/lisp/textmodes/sgml-mode.el 
b/lisp/textmodes/sgml-mode.el
    Stefan> index b4f5ebf5cd0..d80cdc34775 100644
    Stefan> --- a/lisp/textmodes/sgml-mode.el
    Stefan> +++ b/lisp/textmodes/sgml-mode.el
    Stefan> @@ -66,7 +66,7 @@ When 2, attribute indentation looks like this:
    Stefan> </element>"
    Stefan> :version "25.1"
    Stefan> :type 'integer
    Stefan> -  :safe 'integerp)
    Stefan> +  :safe #'integerp)
    >> 
    >> Isnʼt that already enforced by the ':typeʼ keyword?

    Stefan> No.

If I remove the ':safe' spec, and try to set the value to a string,
M-x customize refuses to apply it, so now I wonder when this failure
to enforce occurs.

    >> If so, we have lots of redundant ':safe' in defcustoms.

    Stefan> It's not redundant: one describe the set of values that are 
meaningful
    Stefan> (so as to allow Custom to provide a more helpful UI), the other
    Stefan> specifies which values are believed to be safe when coming from
    Stefan> untrusted sources.

    Stefan> They're closely related and often identical, but not always.

Iʼm having a hard time coming up with a situation where they wouldnʼt
be identical, but I guess they exist in the wild.

Robert
--