Re: [PATCH] notifications: Don't expand-file-name app-icon.

[Andrew Tropin]

On 2023-07-25 15:51, Eli Zaretskii wrote:

>> From: Michael Albinus <michael.albinus@gmx.de>
>> Cc: Andrew Tropin <andrew@trop.in>,  emacs-devel@gnu.org
>> Date: Tue, 25 Jul 2023 12:43:41 +0200
>> 
>> Perhaps we extend the arguments of `notifications-notify'? :app-icon
>> should be either a string (a file name, which is expanded), or a symbol,
>> which denotes one of the Standard Action Icons of the Icon Naming 
>> Specification.
>> 
>> Your example would read in Lisp then
>> 
>> --8<---------------cut here---------------start------------->8---
>> (notifications-notify :title "I am playing music" :app-icon 
>> 'multimedia-player)
>> --8<---------------cut here---------------end--------------->8---
>> 
>> WDYT?
>
> SGTM, thanks.

Does it make sense to introduce edge-case and differentiate between
strings and symbols?  Removing expand-file-name seems to be backward
compatible and simple solution, but if there is some good reason for
symbol/string solution - let me know, I will update the patch.

-- 
Best regards,
Andrew Tropin

signature.asc
Description: PGP signature