[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master 508d24c8b9a 4/4: ; Silence byte-compiler
From: |
Basil L. Contovounesios |
Subject: |
Re: master 508d24c8b9a 4/4: ; Silence byte-compiler |
Date: |
Mon, 21 Aug 2023 04:35:54 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Stefan Kangas [2023-08-20 20:28 +0200] wrote:
> Basil L. Contovounesios <contovob@tcd.ie> writes:
> I cherry-picked the change to emacs-29, thanks.
Thanks.
>> > +(defvar native-comp-eln-load-path)
>> > (ert-deftest comp-tests-bootstrap ()
>> > "Compile the compiler and load it to compile it-self.
>> > Check that the resulting binaries do not differ."
>>
>> Would it be better to move the declaration within the test's body,
>> which is tagged as :nativecomp? Or is the warning emitted in
>> --with-native-compilation builds as well?
>
> Why would it be better to move it within the test's body?
Perhaps to limit its dynamic scope to when the variable is
defined/tested, if preferred.
--
Basil