Re: Proposal to add Popper to ELPA

[Mauro Aranda]

On 5/9/23 17:12, Karthik Chikmagalur wrote:

> In case you missed it during the review, the package has two files:
> `popper.el' and `popper-echo.el'.  (The latter provides 
`popper-echo-mode',
> which adds echo-area display of available popups and allows for quick
> selection using a transient keymap.)

I took a look at the defcustoms in popper-echo.el.  Here are my proposed
changes:

diff --git a/popper-echo.el b/popper-echo.el
index 0369840..b19d7cb 100644
--- a/popper-echo.el
+++ b/popper-echo.el
@@ -58,7 +58,8 @@ This is called on buffer-names displayed by `popper-echo'.

 This function should accept a
   string (the buffer name) and return a transformed string."
-  :type 'function
+  :type '(choice (const :tag "Don't transform buffer-names" nil)
+                 function)
   :group 'popper)

 (defcustom popper-echo-lines 2
@@ -102,7 +103,7 @@ Examples:

 This variable has no effect when popper-echo-mode is turned
 off."
-  :type '(group character string)
+  :type '(repeat (choice character string))
   :group 'popper)

 (defface popper-echo-area-buried