emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Proposal to add Popper to ELPA


From: Karthik Chikmagalur
Subject: Re: Proposal to add Popper to ELPA
Date: Tue, 05 Sep 2023 13:49:29 -0700

>  > -  :type '(restricted-sexp :match-alternatives (stringp symbolp 
> functionp consp))
>  > -  :group 'popper)
>  > +  :type '(repeat (string :tag "Regular Expression")
>  > +           (symbol :tag "Major Mode")
>  > +           (function :tag "Predicate Function")
>  > +           ;; What is the consp in (restricted-sexp :match-alternatives 
> (stringp symbolp functionp consp))?
>  > +           ))
>
> The different alternatives should be inside a choice:
> :type '(repeat (choice (string :tag "Regular Expression")
>                         (symbol :tag "Major Mode")
>                         (function :tag "Predicate Function"))

In addition, cons cells of the form '(string-or-symbol . hide) are
allowed.  I'm not sure how to represent this in the customization types
list.  I'm okay with omitting this from the customize interface, since
it's a niche option that few users will need.

>  >   (defcustom popper-mode-line-position 0
>  >     "Position in mode-line to place `popper-mode-line'."
>  > -  :type 'integer
>  > -  :group 'popper)
>  > +  :type 'natnum)
>
> IIUC, the package requires Emacs 26.1, and the natnum widget wasn't
> available back then.  Does Compat have it?

Thanks for checking.  I will revert the type to 'integer for now.

Karthik



reply via email to

[Prev in Thread] Current Thread [Next in Thread]