[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 160b4c295d8: ; * src/process.c (child_signal_notify): Avoid c

From: Robert Pluim
Subject: Re: master 160b4c295d8: ; * src/process.c (child_signal_notify): Avoid compiler warning (bug#65919).
Date: Mon, 18 Sep 2023 15:51:20 +0200

>>>>> On Fri, 15 Sep 2023 02:05:43 -0400 (EDT), Eli Zaretskii <eliz@gnu.org> 
>>>>> said:

    Eli> branch: master
    Eli> commit 160b4c295d8975755d4a8cc4ba6b6b75a549ed3c
    Eli> Author: Eli Zaretskii <eliz@gnu.org>
    Eli> Commit: Eli Zaretskii <eliz@gnu.org>

    Eli>     ; * src/process.c (child_signal_notify): Avoid compiler warning 
    Eli> ---
    Eli>  src/process.c | 18 ++++++++++++------
    Eli>  1 file changed, 12 insertions(+), 6 deletions(-)

    Eli> diff --git a/src/process.c b/src/process.c
    Eli> index 7410256dae9..2376d0f288d 100644
    Eli> --- a/src/process.c
    Eli> +++ b/src/process.c
    Eli> @@ -7415,10 +7415,14 @@ child_signal_notify (void)
    Eli>    int fd = child_signal_write_fd;
    Eli>    eassert (0 <= fd);
    Eli>    char dummy = 0;
    Eli> -  if (emacs_write (fd, &dummy, 1) != 1)
    Eli> -    /* This call is commented out.  It calls `emacs_perror', which in
    Eli> -       turn invokes a localized version of strerror that is not
    Eli> -       reentrant and must not be called within a signal
    Eli> handler:

Is it worth the effort to use strerror_r-posix here from Gnulib? Weʼd
have to use a static char buffer to avoid malloc, but it might be
better than nothing.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]