Re: master 1d60139a807: Add toggle-window-dedicated command and mode-line-window-dedicated

[Eshel Yaron]

Hi,

>     ...Let's display the window dedicated status in the mode-line to help
>     indicate what's going on.
>
>     (standard-mode-line-format): Insert mode-line-window-dedicated.

[...]

> @@ -676,8 +705,9 @@ By default, this shows the information specified by 
> `global-mode-string'.")
>                   'mode-line-mule-info
>                   'mode-line-client
>                   'mode-line-modified
> -                 'mode-line-remote)
> -              'display '(min-width (5.0)))
> +                 'mode-line-remote
> +                 'mode-line-window-dedicated)
> +              'display '(min-width (6.0)))
>            'mode-line-frame-identification
>            'mode-line-buffer-identification

AFAICT this takes an extra space before the buffer identification in all
mode lines, is that really justified for indicating window dedication?
I wonder if it wouldn't be better to keep the mode line as it is in
non-dedicated windows and only make dedicated windows "pay the cost" in
mode line space.  FWIW I have the following in my `mode-line-format`
after `minor-mode-alist`:

    (:eval (when (window-dedicated-p) " Dedicated"))

That way window dedication is indicated in the mode line in a similar
way to how minor modes and narrowing is indicated.  I'm not sure that's
ideal, by it doesn't take up mode line space in the common case (for me)
of non-dedicated windows.


Best,

Eshel