|
From: | Yuan Fu |
Subject: | Re: rust-ts-mode: appropriately fontify doc strings |
Date: | Fri, 1 Dec 2023 19:41:15 -0800 |
User-agent: | Mozilla Thunderbird |
On 12/1/23 3:58 PM, Dmitry Gutov wrote:
On 01/12/2023 10:25, Christophe TROESTLER wrote:Hi,On 1 December 2023 at 01:50 +01, Dmitry Gutov<dmitry@gutov.dev> wrote:Thanks for your feedback. I did dome tests and the two are comparable (on Emacs 29.1) but here is a version that uses your suggestion.On 30/11/2023 01:21, Christophe TROESTLER wrote:+ (prefix (buffer-substring-no-properties beg (min (+ beg 3) end)))+ (face (if (string-equal "///" prefix)It'll probably be faster overall to use save-excursion and looking-at instead of creating a substring.Thanks! I'd rather err on the side of this one, even if initial testing shows the approaches are comparable. It's good to have verified that it's not slower, anyway.I've pushed it to emacs-29. In the future, please send patches to the bug tracker, though (then it's easier to ensure they are not lost).
Thanks to you both! Yuan
[Prev in Thread] | Current Thread | [Next in Thread] |