[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master d8a00879309: Cease preloading touch-screen.el outside X and A
From: |
Eli Zaretskii |
Subject: |
Re: master d8a00879309: Cease preloading touch-screen.el outside X and Android |
Date: |
Thu, 07 Dec 2023 08:35:52 +0200 |
> From: Arash Esbati <arash@gnu.org>
> Cc: Po Lu <luangruo@yahoo.com>
> Date: Wed, 06 Dec 2023 23:12:21 +0100
>
> Po Lu via Mailing list for Emacs changes <emacs-diffs@gnu.org> writes:
>
> > branch: master
> > commit d8a00879309a3bf62f6ffcae103aa3bdba776ee9
> > Author: Po Lu <luangruo@yahoo.com>
> > Commit: Po Lu <luangruo@yahoo.com>
> >
> > Cease preloading touch-screen.el outside X and Android
> >
> > * lisp/calc/calc.el (touch-screen-display-keyboard):
> >
> > * lisp/minibuffer.el (clear-minibuffer-message):
> >
> > * lisp/term.el (touch-screen-display-keyboard): Declare
> > touch-screen-display-keyboard before binding or setting it.
> >
> > * lisp/loadup.el: Don't autoload touch-screen.el outside X and
> > Android.
> >
> > * lisp/touch-screen.el: Autoload functions called from commands
> > responding to touch screen events.
>
> I think this change produces these warnings:
>
> In end of data:
> button.el:498:26: Warning: the function ‘touch-screen-track-tap’ is not
> known to be defined.
>
> In clear-minibuffer-message:
> minibuffer.el:979:23: Warning: reference to free variable
> ‘touch-screen-current-tool’
>
> In tab-bar-touchscreen-begin:
> tab-bar.el:440:55: Warning: reference to free variable
> ‘touch-screen-delay’
>
> In end of data:
> dired.el:5185:8: Warning: the function ‘touch-screen-hold’ is not known
> to be defined.
>
> In tab-line-track-tap:
> tab-line.el:978:50: Warning: reference to free variable
> ‘touch-screen-delay’
>
> This is with Emacs from master (d8a0087930) on macOS, built with:
>
> git clean -fdx
> ./autogen
> ./configure ...
> make
The two functions are autoloaded, so I'm guessing that the warnings go
away once loaddefs.el is generated.
The variables indeed need a defvar, I think.