Re: master 3b1fd42732f: * lisp/loadup.el: Check advice after `rmc.el`; turn error into warning

[Jens Schmidt]

On 2023-12-07  19:14, Stefan Monnier wrote:
> branch: master
> commit 3b1fd42732f7ca5b2db6ad6e75af1c037e1c54e4
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Commit: Stefan Monnier <monnier@iro.umontreal.ca>
> 
>     * lisp/loadup.el: Check advice after `rmc.el`; turn error into warning

I don't mind the error => warning change, we have been discussing
that in a slightly different context, anyway.

But when I tried to place that advice-checking-code into loadup.el,
I also saw this rmc.el and didn't quite know what to do with it.  I
thought that Lars might have placed it *inadvertently* after the

  (load "site-load" t)

block, because, um, logically it belongs to before that, doesn't it?
First all the core libraries get preloaded (including rmc.el), then
any site-specific libraries.

So probably TRT here would be to place these paragraphs as follows:

0. (load "leim/leim-list.el" t)

1. (load "emacs-lisp/rmc")

2. Check for advices (on core libs only).

3. (load "site-load" t)

4. "default-directory must be unibyte"

What do you think?