Re: master 3b1fd42732f: * lisp/loadup.el: Check advice after `rmc.el`; turn error into warning

[Stefan Monnier]

> But when I tried to place that advice-checking-code into loadup.el,
> I also saw this rmc.el and didn't quite know what to do with it.  I
> thought that Lars might have placed it *inadvertently* after the
>
>   (load "site-load" t)
>
> block, because, um, logically it belongs to before that, doesn't it?

That was also my impression, indeed.

> So probably TRT here would be to place these paragraphs as follows:
>
> 0. (load "leim/leim-list.el" t)
>
> 1. (load "emacs-lisp/rmc")
>
> 2. Check for advices (on core libs only).
>
> 3. (load "site-load" t)
>
> 4. "default-directory must be unibyte"
>
> What do you think?

I decided that it was OK to keep "check for advice" after loading
`site-load` now that it's a warning.  IOW I don't have a strong opinion
on the order between `2` and `3`.
But I agree that `rmc` should come before those two.


        Stefan