Re: man broken?

[Michael Albinus]

Po Lu <luangruo@yahoo.com> writes:

Hi,

> Should the body of this macro be extracted into a separate function, so
> that future changes affecting it won't require a recompilation of all
> files where it is invoked?  I've seen two breaking changes with this
> macro involved in some capacity over the past 30 days, which is abnormal
> for such a widely used macro.

This macro isn't widely used, just 5 files outside files-x.el:.

--8<---------------cut here---------------start------------->8---
# grep '(connection-local-value' lisp/*.el lisp/**/*.el
lisp/dired.el:          (setq switches (connection-local-value 
dired-listing-switches)))
lisp/dired.el:              (or switches (connection-local-value 
dired-listing-switches)))
lisp/dired-x.el:   dirname (or switches (connection-local-value 
dired-listing-switches)))
lisp/files.el:        (let ((switches (connection-local-value 
dired-listing-switches)))
lisp/files.el:     (concat (connection-local-value dired-listing-switches) " 
-t")))
lisp/files-x.el:  (connection-local-value path-separator))
lisp/files-x.el:  (connection-local-value null-device))
lisp/man.el:      (connection-local-value shell-file-name)
lisp/net/ange-ftp.el:                               (connection-local-value
--8<---------------cut here---------------end--------------->8---

The macro is newly added to Emacs, so it isn't abnormal that the usage
shows potential problems. The breakage came due to a thinko of mine, I
don't expect further changes to the macro. (I know, famous last words ...)

Best regards, Michael.