emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 78fc49407b8 1/3: Improve filling of ChangeLog entries


From: Po Lu
Subject: Re: master 78fc49407b8 1/3: Improve filling of ChangeLog entries
Date: Wed, 31 Jan 2024 14:43:59 +0800
User-agent: Gnus/5.13 (Gnus v5.13)

João Távora <joaotavora@gmail.com> writes:

> Seems like this much simpler patch would have done the job.  If cl-loop
> is so toxic, even macroexpanding these trivial ones away yields much
> less code and much simpler code.  Tests are a welcome addition though.

I did not understand the code using cl-loop, and there are no comments
in this version of the change.  For that matter, if there _were_
comments in the original version, I could have understood its intent,
but cryptic cl-lib and pcase labyrinths are all the rage these days.

Anyway, please don't modify log-edit just yet--I plan to modify it to
handle conditional changes and part indicators.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]