Re: master a2201a2034a: (loaddefs-generate--parse-file): Be a bit more defensive

[Arash Esbati]

Stefan Monnier via Mailing list for Emacs changes <emacs-diffs@gnu.org> writes:

> branch: master
> commit a2201a2034a86b4cc90132ab2d920456866c11e3
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Commit: Stefan Monnier <monnier@iro.umontreal.ca>
>
>     (loaddefs-generate--parse-file): Be a bit more defensive
>     
>     * lisp/emacs-lisp/loaddefs-gen.el (loaddefs-generate--parse-file):
>     Don't fail in case of an error while generating the prefixes.
>     (loaddefs-generate--compute-prefixes): Don't burp when
>     `read-from-string` returns something else than a symbol.
> ---
> [...]
>  (defun loaddefs-generate--compute-prefixes (load-name)
> @@ -506,14 +508,15 @@ don't include."
>                 ;; Consider `read-symbol-shorthands'.
>                 (probe (let ((obarray (obarray-make)))
>                          (car (read-from-string name)))))
> -          (setq name (symbol-name probe))
> -          (when (save-excursion
> -                  (goto-char (match-beginning 0))
> -                  (or (bobp)
> -                      (progn
> -                        (forward-line -1)
> -                        (not (looking-at ";;;###autoload")))))
> -            (push name prefs)))))
> +          (when (symbolp name)
> +            (setq name (symbol-name probe))

I have no clue about the code, but shouldn't this read:

+          (when (symbolp name)
                          ^^^^ -> probe

?  I think this is also suggested by Philip K. in this message[1].

Best, Arash

Footnotes:
[1]  https://lists.gnu.org/archive/html/bug-gnu-emacs/2024-02/msg00249.html