[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master 9ccaa09a635: ; .dir-locals.el (log-edit-mode) <fill-column>:
From: |
Eli Zaretskii |
Subject: |
Re: master 9ccaa09a635: ; .dir-locals.el (log-edit-mode) <fill-column>: Set to 64. |
Date: |
Thu, 08 Feb 2024 22:30:40 +0200 |
> Date: Thu, 8 Feb 2024 12:21:37 -0800
> Cc: luangruo@yahoo.com, stefankangas@gmail.com, emacs-devel@gnu.org
> From: Jim Porter <jporterbugs@gmail.com>
>
> >> This, and other bullet points are all talking in the context of a single
> >> commit. But this paragraph talks about multiple ChangeLog entries within
> >> one commit (*after* the summary line and descriptive paragraph). After
> >> carefully reading this, I think it means that one ChangeLog entry is a
> >> line of the form "* some/file.el (function): Frobnicate the widget."
> >
> > Yes. But where did you see any verbiage to the contrary?
>
> The first sentence of the section begins, "Ordinarily, a change you
> commit should contain a log entry in its commit message...". That is,
> there's just one log entry in the commit message. Here, it mentions
> multiple entries in a single commit.
So that single use of "entry" (not "ChangeLog entry", mind you) was
what confused you? very well, now that single instance is gone as
well.
> In practice, I think this section of CONTRIBUTE is clear enough for
> people to understand how to properly-format their commit messages, and
> my main confusion was in whether to account for TAB characters in the
> ChangeLog *files* when counting columns for wrapping.
The text talks about ChangeLog entries in a commit log message, and
explicitly says "unindented", so the answer is definitely NO.
Thanks.
- Re: master 9ccaa09a635: ; .dir-locals.el (log-edit-mode) <fill-column>: Set to 64., Stefan Kangas, 2024/02/07
- Re: master 9ccaa09a635: ; .dir-locals.el (log-edit-mode) <fill-column>: Set to 64., Po Lu, 2024/02/07
- Re: master 9ccaa09a635: ; .dir-locals.el (log-edit-mode) <fill-column>: Set to 64., Jim Porter, 2024/02/07
- Re: master 9ccaa09a635: ; .dir-locals.el (log-edit-mode) <fill-column>: Set to 64., Po Lu, 2024/02/07
- Re: master 9ccaa09a635: ; .dir-locals.el (log-edit-mode) <fill-column>: Set to 64., Jim Porter, 2024/02/08
- Re: master 9ccaa09a635: ; .dir-locals.el (log-edit-mode) <fill-column>: Set to 64., Eli Zaretskii, 2024/02/08
- Re: master 9ccaa09a635: ; .dir-locals.el (log-edit-mode) <fill-column>: Set to 64., Jim Porter, 2024/02/08
- Re: master 9ccaa09a635: ; .dir-locals.el (log-edit-mode) <fill-column>: Set to 64., Eli Zaretskii, 2024/02/08
- Re: master 9ccaa09a635: ; .dir-locals.el (log-edit-mode) <fill-column>: Set to 64., Jim Porter, 2024/02/08
- Re: master 9ccaa09a635: ; .dir-locals.el (log-edit-mode) <fill-column>: Set to 64.,
Eli Zaretskii <=
- Re: master 9ccaa09a635: ; .dir-locals.el (log-edit-mode) <fill-column>: Set to 64., Stefan Kangas, 2024/02/17
- Re: master 9ccaa09a635: ; .dir-locals.el (log-edit-mode) <fill-column>: Set to 64., Po Lu, 2024/02/17
- Re: master 9ccaa09a635: ; .dir-locals.el (log-edit-mode) <fill-column>: Set to 64., Eli Zaretskii, 2024/02/08