Re: master babe6a5e948 1/2: Introduce a new TRAMP method `androidsu'

[Po Lu]

Michael Albinus <michael.albinus@gmx.de> writes:

> -(defconst tramp-androidsu-method "androidsu"
> +(defconst tramp-androidsu-method "su"
>    "When this method name is used, forward all calls to su.")
>
>  ;;;###tramp-autoload
> @@ -66,10 +66,7 @@ tramp-androidsu-su-mm-supported
>                  (tramp-remote-shell-login   ("-l"))
>                  (tramp-remote-shell-args    ("-c"))
>                  (tramp-tmpdir               "/data/local/tmp")
> -                (tramp-connection-timeout   10)))
> -
> - (add-to-list 'tramp-default-host-alist
> -              `(,tramp-androidsu-method nil "localhost")))
> +                (tramp-connection-timeout   10))))
>
>  (defvar android-use-exec-loader) ; androidfns.c.
>
> @@ -645,7 +642,8 @@ tramp-androidsu-file-name-handler-alist
>  (defsubst tramp-androidsu-file-name-p (vec-or-filename)
>    "Check whether VEC-OR-FILENAME is for the `androidsu' method."
>    (when-let* ((vec (tramp-ensure-dissected-file-name vec-or-filename)))
> -    (equal (tramp-file-name-method vec) tramp-androidsu-method)))
> +    (and (eq system-type 'android)
> +         (equal (tramp-file-name-method vec) tramp-androidsu-method))))
>
>  ;;;###tramp-autoload
>  (defun tramp-androidsu-file-name-handler (operation &rest args)

I've yet to test this patch, but nevertheless won't it override the
default file name handlers even in multi-hop connections, where su will
definitely not be executed under Android?