Re: master babe6a5e948 1/2: Introduce a new TRAMP method `androidsu'

[Michael Albinus]

Po Lu <luangruo@yahoo.com> writes:

Hi,

>> No. In multi-hop connections, every hop is checked via
>> tramp-multi-hop-p. This includes tramp-sh-file-name-handler-p, which
>> returns nil for the tramp-androidsu backend.
>
> That raises a different question: won't such a check disable multi-hop
> connections involving the `su' method from being established to
> non-Android hosts?  Is it possible to detect whether VEC appertains to a
> multi-hop connection early, in tramp-androidsh-file-name-handler-p
> itself?

Good question. So perhaps we must improve the check like (untested)

(defsubst tramp-androidsu-file-name-p (vec-or-filename)
  "Check whether VEC-OR-FILENAME is for the `androidsu' method."
  (when-let* ((vec (tramp-ensure-dissected-file-name vec-or-filename)))
    (and (eq system-type 'android)
         (equal (tramp-file-name-method vec) tramp-androidsu-method)
         (null (tramp-file-name-hop vec)))))

Best regards, Michael.