Re: master 1d9d07fb00e 3/3: (cl--typeof-types): Rework to fix some regressions

[Andrea Corallo]

Andrea Corallo <acorallo@gnu.org> writes:

> Stefan Monnier via Mailing list for Emacs changes <emacs-diffs@gnu.org>
> writes:
>
>> branch: master
>> commit 1d9d07fb00e6b62641c07af68f986e700b5f6cee
>> Author: Stefan Monnier <monnier@iro.umontreal.ca>
>> Commit: Stefan Monnier <monnier@iro.umontreal.ca>
>>
>>     (cl--typeof-types): Rework to fix some regressions
>>     
>>     Initialize the variables directly in their declaration, so
>>     there no time where they exist but aren't yet initialized.
>>     This also allows us to mark `cl--typeof-types` as a `defconst` again.
>>     
>>     More importantly, specify the DAG by direct supertypes rather
>>     than direct subtypes.  This is slightly less compact, but it's
>>     necessary to let us specify the *order* of the supertypes,
>>     which is necessary for example to preserve the desired ordering
>>     of methods when several methods can be applied.
>
> Hi Stefan,
>
> I'm not sure I understand.  Is some code relying on the "order" of the
> supertypes?  Are these the regression you are mentioning?
>
> Must say I'm surprised supertypes can have an "order" in first place.

Also, this commit makes etc/syncdoc-type-hierarchy.el not functional and
our doc out of sync (it removes the comment asking to run
etc/syncdoc-type-hierarchy.el when changing 'cl--type-hierarchy' as well
🙁).

  Andrea