Re: [PATCH] Flymake Support Indicator Errors in Margin

[Eli Zaretskii]

> From: Elijah G <eg642616@gmail.com>
> Date: Wed, 13 Mar 2024 19:50:59 -0600
> Cc: philipk@posteo.net, emacs-devel@gnu.org
> 
>  I think this is a mistake: it makes this change backward-incompatible,
>  in the sense that users who had customizations of the options you are
>  removing will now have to rework their customizations.  We try to
>  avoid backward-incompatible changes like this as much as possible.  It
>  doesn't sound to me like this part of the patch is strictly needed, is
>  it?
> 
>  
> You are right, i was planning something like marking those variables as 
> deprecated for 30,
> but since it makes backward incompatible think it can be too early to do it 
> in this patch,
> However I find merging them easier to customize instead of defining them 
> separately.
> 
> If these variables are necessary, I've now reverted the changes in the patch.

Thanks.

> +(defcustom flymake-margin-indicators-string
> +  `((error ,(if (char-displayable-p 8252)
> +               "‼"
> +             "!!")
> +     compilation-error)

When do you expect this value to be evaluated?

In general, I wonder whether it would be simpler and wiser to use just
"!!", and leave it to users to customize to "‼" if their displays
support that.  (We can mention the possibility in the doc string.)

João, any comments?