emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 8d4a8b7dfd0: ; Re-apply accidentally reverted commit


From: Kévin Le Gouguec
Subject: Re: master 8d4a8b7dfd0: ; Re-apply accidentally reverted commit
Date: Mon, 18 Mar 2024 20:02:06 +0100
User-agent: Gnus/5.13 (Gnus v5.13)

john muhl <jm@pub.pink> writes:

> The test you added here fails when run by a user that doesn’t have
> Git configured. When run by such a user the ‘git commit -mFirst’
> command errors which causes the test to fail:
>
>   $ git commit -mFirst
>   Author identity unknown
>
>   *** Please tell me who you are.

I can reproduce the failure running 'EMAIL= make test' (since EMAIL is
how I let Git know about my email, rather than ~/.gitconfig:user.email).
The attached patch lets the test pass; let me know if it looks sensible?
I'll install it then.

Attachment: 0001-Fix-vc-git-test-when-no-identities-are-configured.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]