[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master 8d4a8b7dfd0: ; Re-apply accidentally reverted commit
From: |
john muhl |
Subject: |
Re: master 8d4a8b7dfd0: ; Re-apply accidentally reverted commit |
Date: |
Mon, 18 Mar 2024 20:46:57 -0500 |
User-agent: |
mu4e 1.10.8; emacs 30.0.50 |
Kévin Le Gouguec <kevin.legouguec@gmail.com> writes:
> john muhl <jm@pub.pink> writes:
>
>> The test you added here fails when run by a user that doesn’t have
>> Git configured. When run by such a user the ‘git commit -mFirst’
>> command errors which causes the test to fail:
>>
>> $ git commit -mFirst
>> Author identity unknown
>>
>> *** Please tell me who you are.
>
> I can reproduce the failure running 'EMAIL= make test' (since EMAIL is
> how I let Git know about my email, rather than ~/.gitconfig:user.email).
> The attached patch lets the test pass; let me know if it looks sensible?
> I'll install it then.
>
> [2. text/x-patch;
> 0001-Fix-vc-git-test-when-no-identities-are-configured.patch]...
Thanks the test passes here too.