Re: [PATCH] Implement fast verisons of json-parse functions

[Herman , Géza]

Eli Zaretskii <eliz@gnu.org> writes:

> > If we want to have conditional compilation, is there a simple
> > similar conditional compilation case already in Emacs?  So I 
> > can
> > copy the approach easily (supposedly I need to add a flag to
> > configure, it needs to add a -DUSE_OWN_JSON_PARSER switch to 
> > the
> > compiller, etc.)
>
> Let's wait with this until we have a clear idea whether we need 
> this.
> My suggestion was just to present a possibility, not necessarily 
> a
> decision that we should have this.  I'm not sure yet whether we 
> need
> to offer the possibility of using libjansson for parsing JSON as 
> an
> option.

What is the process for deciding this?

I attached the latest version of the parser.  I reverted the Lisp 
vector based workspace to use a malloc based one, and added a note 
regarding that the GC most not run during parsing.  I also 
implemented some additional optimizations, this version runs ~10x 
faster on my LSP dataset.  I also run the parser on all the JSON 
files I found on my computer (~60,000 files, 1.5 GiB), no problems 
were found.  The parser runs ~6.5x faster (3.5 sec vs 23.4 sec) on 
this dataset.

0001-replace-jansson-parser-with-a-custom-one.patch
Description: Text Data