emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 49ef173b028: Make publishDiagnostics faster by using cached v


From: João Távora
Subject: Re: master 49ef173b028: Make publishDiagnostics faster by using cached variable
Date: Mon, 22 Apr 2024 15:42:56 +0100

On Mon, Apr 22, 2024 at 3:30 PM Michael Albinus <michael.albinus@gmx.de> wrote:
>
> Theodor Thornhill via Mailing list for Emacs changes
> <emacs-diffs@gnu.org> writes:
>
> >     * test/lisp/progmodes/eglot-tests.el (eglot-test-basic-symlink): Add
> >     regression test for symlink behavior
>
> This test fails on EMBA. Since there is clangd 11, perhaps a version
> check is needed like in other tests?


I don't think that's the issue.  The test just needs to be made more robust
and give the server some time to analyze code.  I've seen this failure on
an Archlinux VM with clangd 17, which is fairly recent.

The test should wait and assert the proper server LSP responses instead of
implmentation details the xref.el user interface.

The performance optimization that preceded the test is also buggy anyway, and I
have to redo it.  It fails blatantly on Windows (probably if you're on Windows 
using Eglot there are no diags at all right now.  let's follow up on 70408, which 
is where all the details are.  Thanks

reply via email to

[Prev in Thread] Current Thread [Next in Thread]