[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Incorporate package macrostep into Emacs core
From: |
Eli Zaretskii |
Subject: |
Re: Incorporate package macrostep into Emacs core |
Date: |
Sat, 27 Apr 2024 12:52:29 +0300 |
> From: Jeremy Bryant <jb@jeremybryant.net>
> Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
> Date: Thu, 25 Apr 2024 22:27:56 +0100
>
> Absolutely, sorry, attached is the revised patch I have worked on.
Thanks, a few minor comments below.
> Subject: [PATCH] Add Macrostep section in manual
>
> Macrostep is an Emacs Lisp macro-expander useful for exploring and
> writing macros. This is based on Jonathan's Oddie's documentation
> in the macrostep package.
>
> * doc/emacs/programs.texi (Programs): Add Macrostep section.
> * doc/emacs/emacs.texi (Top): Add detailed menu reference.
^^^^^^^ ^^^
Those TABs should not be there in the commit log message.
> +You can use @code{macrostep-mode} to explore Lisp macro definitions, and
> +help write new macros, using @kbd{M-x macrostep-expand} when point is
> +over a macro.
We say "when point is in a macro". "Over" is reserved for mouse
pointer.
> +@kbd{macrostep} is a minor mode for interactively stepping through the
^^^^^^^^^
"macrostep-mode", I guess? And why @kbd? is that something the user
is supposed to type?
> +The standard keybindings in @code{macrostep-mode} are the following:
> +@table @kbd
> +@item e
> +@itemx =
> +@itemx RET
> +@findex macrostep-expand
Please move the index entries to _before_ the corresponding @item's,
so that following the index entry lands you on the @item, not after
it.
Otherwise, this LGTM, thanks.
- Re: Incorporate package macrostep into Emacs core, (continued)
- Re: Incorporate package macrostep into Emacs core, Eli Zaretskii, 2024/04/19
- Re: Incorporate package macrostep into Emacs core, Eli Zaretskii, 2024/04/20
- Re: Incorporate package macrostep into Emacs core, Jeremy Bryant, 2024/04/23
- Re: Incorporate package macrostep into Emacs core, Eli Zaretskii, 2024/04/25
- Re: Incorporate package macrostep into Emacs core, Jeremy Bryant, 2024/04/25
- Re: Incorporate package macrostep into Emacs core, Eshel Yaron, 2024/04/26
- Re: Incorporate package macrostep into Emacs core,
Eli Zaretskii <=
- Re: Incorporate package macrostep into Emacs core, Jeremy Bryant, 2024/04/29