Re: Shell quoting in Eshell (was: eshell-batch-file)

[Eli Zaretskii]

> Date: Sun, 9 Jun 2024 15:37:05 -0700
> From: Jim Porter <jporterbugs@gmail.com>
> Cc: emacs-devel@gnu.org
> 
> There are just two changes you made that I'm not quite sure what to do 
> about. When you get the chance, could you apply the following patch and 
> report back the test failures you get?

I get this failure:

  Test esh-proc-test/kill-pipeline backtrace:
    signal(ert-test-failed (((should (string-match-p (rx (or "interrupt\
    ert-fail(((should (string-match-p (rx (or "interrupt\n" "killed\n" "
    (if (unwind-protect (setq value-164 (apply fn-162 args-163)) (setq f
    (let (form-description-166) (if (unwind-protect (setq value-164 (app
    (let ((value-164 'ert-form-evaluation-aborted-165)) (let (form-descr
    (let* ((fn-162 #'string-match-p) (args-163 (condition-case err (list
    (let ((output-start (eshell-beginning-of-output))) (eshell-kill-proc
    (save-current-buffer (set-buffer eshell-buffer) (eshell-insert-comma
    (unwind-protect (save-current-buffer (set-buffer eshell-buffer) (esh
    (let ((eshell-buffer (eshell t))) (unwind-protect (save-current-buff
    (let ((process-environment (cons "HISTFILE" process-environment)) (e
    (progn (let ((process-environment (cons "HISTFILE" process-environme
    (unwind-protect (progn (let ((process-environment (cons "HISTFILE" p
    (let* ((coding-system-for-write nil) (temp-file (file-name-as-direct
    (save-current-buffer (let* ((coding-system-for-write nil) (temp-file
    #f(lambda () [t] (let ((value-155 (gensym "ert-form-evaluation-abort
    #f(compiled-function () #<bytecode -0x1b68e6722d1837b4>)()
    handler-bind-1(#f(compiled-function () #<bytecode -0x1b68e6722d1837b
    ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
    ert-run-test(#s(ert-test :name esh-proc-test/kill-pipeline :document
    ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
    ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil
    ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp))))
    ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco
    eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n
    command-line-1(("-L" ";." "-l" "ert" "--eval" "(setq treesit-extra-l
    command-line()
    normal-top-level()
  Test esh-proc-test/kill-pipeline condition:
      (ert-test-failed
       ((should
         (string-match-p (rx ...)
                         (buffer-substring-no-properties output-start ...)))
        :form
        (string-match-p "\\(?:\\(?:interrupt\\|killed\\(?:: 9\\)?\\)\n\\)"
                        "")
        :value nil))
     FAILED   4/23  esh-proc-test/kill-pipeline (0.131174 sec) at 
lisp/eshell/esh-proc-tests.el:283

Why do we expect to see "killed" or "interrupt" in this case?