Re: [NonGNU ELPA] New package org-transclusion-http

[Joseph Turner]

Thank you for the review!

Philip Kaludercic <philipk@posteo.net> writes:

> There is really not much I can comment on, since it is mainly API I am
> not familiar with.  One note is that the package description doesn't
> make much sense to me, since I don't know what "transcluding" means.
> Also, not everyone knows that "plz" is a HTTP library (the name remains
> elusive), so a brief comment reminding the reader of that would be
> appropriate.

I've updated the package description.

> Another note is that if you already have a .dir-locals.el file, you
> could add a few more variables that might vary from system to system.
> In Compat, the .dir-locals.el lists:
>
> --8<---------------cut here---------------start------------->8---
> ((nil
>   (fill-column . 72)
>   (sentence-end-double-space . t)
>   (show-trailing-whitespace . t)
>   (indent-tabs-mode . nil)))
> --8<---------------cut here---------------end--------------->8---

I've added all these variables except show-trailing-whitespace, as I
don't personally use it.  ws-butler takes care of whitespace without
adding visuals.

> Also, I think an .elpaigore file would be appropriate to have in the
> repo, at least to avoid bundling the build-time dependencies.

I've added .elpaignore and pushed a new release v0.3.

Thank you!!!

Joseph