Re: master 6aa5068ac71 1/3: Improve treatment of touch screen input by rmc and its callers

[Po Lu]

Arash Esbati <arash@gnu.org> writes:

> Po Lu via Mailing list for Emacs changes <emacs-diffs@gnu.org> writes:
>
>> branch: master
>> commit 6aa5068ac71cb1b8e46c299138f99fea44319146
>> Author: Po Lu <luangruo@yahoo.com>
>> Commit: Po Lu <luangruo@yahoo.com>
>>
>>     Improve treatment of touch screen input by rmc and its callers
>>     
>>     * lisp/emacs-lisp/rmc.el (read-multiple-choice--short-answers):
>>     Run touch screen event translation on touch screen events
>>     received, and respond to pinch, tap and scrolling gestures.
>>     
>>     * lisp/net/nsm.el (nsm-query-user): Disable use-dialog-box in
>>     the details window.
>>     
>>     * lisp/touch-screen.el (touch-screen-translate-touch): Autoload.
>> ---
>>  lisp/emacs-lisp/rmc.el | 106 
>> +++++++++++++++++++++++++++++++++----------------
>>  lisp/net/nsm.el        |  11 ++++-
>>  lisp/touch-screen.el   |   1 +
>>  3 files changed, 81 insertions(+), 37 deletions(-)
>>
>> diff --git a/lisp/emacs-lisp/rmc.el b/lisp/emacs-lisp/rmc.el
>> index 378687c0326..883f8bf187f 100644
>> --- a/lisp/emacs-lisp/rmc.el
>> +++ b/lisp/emacs-lisp/rmc.el
>>[...]
>> +                  (cond
>> +                   ((null command)) ; Read another event.
>> +                   ((memq (car-safe command) '(mouse-1 mouse-2))
>> +                    ;; Display the on-screen keyboard if a tap should be
>> +                    ;; registered.
>> +                    (frame-toggle-on-screen-keyboard (selected-frame)
>> +                                                     nil))
>> +                   ;; Respond to scroll and pinch events as if RMC were
>> +                   ;; not in progress.
>> +                   ((eq (car-safe command) 'touchscreen-scroll)
>> +                    (funcall #'touch-screen-scroll command))
>> +                   ((eq (car-safe command) 'touchscreen-pinch)
>> +                    (funcall #'touch-screen-pinch command))
>
> I think this part now generates:
>
> In end of data:
> rmc.el:245:32: Warning: the function ‘touch-screen-pinch’ is not known to be 
> defined.
> rmc.el:243:32: Warning: the function ‘touch-screen-scroll’ is not known to be 
> defined.
>
> This on macOS with Emacs from master (e6f4370c).

OK, what if you replace in:

>> +                   ;; Respond to scroll and pinch events as if RMC were
>> +                   ;; not in progress.
>> +                   ((eq (car-safe command) 'touchscreen-scroll)
>> +                    (funcall #'touch-screen-scroll command))
>> +                   ((eq (car-safe command) 'touchscreen-pinch)
>> +                    (funcall #'touch-screen-pinch command))

#'touch-screen-scroll and #'touch-screen-pinch with 'touch-screen-scroll
and 'touch-screen-pinch?