Re: MPS: Forwording symbols

[Gerd Möllmann]

Helmut Eller <eller.helmut@gmail.com> writes:

> On Sat, Jun 22 2024, Gerd Möllmann wrote:
>
>>> The symbol is needed in store_symval_forwarding.  It looks in the plist
>>> for 'choice and 'range.  In addition to the five symbols mentioned in
>>> the definition of Lisp_Buffer_Objfwd, predicate can also be
>>> 'overwrite-mode, 'vertical-scroll-bar and 'fraction.  I think those have
>>> those properties; weird.
>>
>> I guess then it's better to leave the enum part out. That seems to
>> become too much work. What an ugly corner.
>
> Here is an attempt to use an enum.  I'm not sure that it's easier to
> read and the enum constants have odd names.

Pushed!

I find that so much better, easier to understand and maintain. There is
no question anymore what that predicate can possibly be (and the comment
was wrong, I'm tempted to say of course), we have compile-time support
with an exhaustive switch. We got rid of that void * before that. And so
on. We even spared a word in the struct :-).

Thanks for doing that!