Re: MPS: Win64 testers?

[Eli Zaretskii]

> From: Kien Nguyen <kien.n.quang@gmail.com>
> Date: Sun, 1 Sep 2024 02:36:10 -0700
> Cc: sebastian@sebasmonia.com, pipcet@protonmail.com, emacs-devel@gnu.org, 
>       yantar92@posteo.net
> 
> > Why is it a pain to run Emacs under GDB at all times?  That way we
> > don't install the hook, and the problem doesn't happen in the first
> > place.
> 
> Because without the keyboard hook running, some of the key combinations
> (Windows and Alt + ...) will be handled by Windows instead of Emacs.

And you really need them while debugging?

> That causes using Emacs for a long running time a bit unnatural as I
> need to relearn or rebind the key combinations again.  Also, running
> under gdb is slow and not enjoyable for using Emacs.

Slow because of the hook or because of other reasons?

You should realize that attaching to Emacs when it crashes many times
misses important information, because when Emacs is not running under
the debugger, fatal exceptions go to the top-level exception handler,
which at times loses important information, like exactly which code
caused the crash.  So running an unstable Emacs build outside of GDB
is not recommended on Windows for several good reasons.

In any case, you should be able to invoke remove_w32_kbdhook from the
debugger, as soon as you attach to Emacs.  I hesitate to make the
change you proposed because emacs_abort is called not just when Emacs
is under a debugger, so the change will affect many users who don't
debug Emacs.