Re: Question about dubious code for terminal frames

[Gerd Möllmann]

Andreas Schwab <schwab@suse.de> writes:

> On Sep 02 2024, Gerd Möllmann wrote:
>
>> Andreas Schwab <schwab@suse.de> writes:
>>
>>> On Sep 02 2024, Gerd Möllmann wrote:
>>>
>>>> AFAIU, these two values give the physical size of a terminal (screen,
>>>> window), as returned from the co and li escape sequences on termcap
>>>> frames.
>>>
>>> Only if get_tty_size cannot determine the real size.
>>
>> Hm, yes, thanks. I guess setting cols and rows should then be
>> conditionalized on being unknown?
>
>   if (FrameCols (tty) <= 0)
>     FrameCols (tty) = tgetnum ("co");
>   if (FrameRows (tty) <= 0)
>     FrameRows (tty) = tgetnum ("li");

I eean in adjust_frame_size

  if (new_inner_width != old_inner_width)
    {
      resize_frame_windows (f, new_inner_width, true);

      /* MSDOS frames cannot PRETEND, as they change frame size by
         manipulating video hardware.  */
      if ((FRAME_TERMCAP_P (f) && !pretend) || FRAME_MSDOS_P (f))
        FrameCols (FRAME_TTY (f)) = new_text_cols;