emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Question about dubious code for terminal frames


From: martin rudalics
Subject: Re: Question about dubious code for terminal frames
Date: Mon, 2 Sep 2024 19:32:11 +0200
User-agent: Mozilla Thunderbird

> I think I have the above here. It reads
>
>    /* Assign new sizes.  */
>    FRAME_COLS (f) = new_text_cols;
>    FRAME_LINES (f) = new_text_lines;

It might cause something weird in resize_frame_windows, but that's maybe
only here.

> Anyway. My problem is setting FrameCols/Rows in adjust_frame_size. It's
> not guaranteed that the terminal's size has indeed changed when that is
> done.

You mean the

        FrameRows (FRAME_TTY (f)) =
        FrameCols (FRAME_TTY (f)) =

assignments?  These are from the pre-2014 change_frame_size_1 code with
the comments mostly preserved and governed by similar conditions.  Do
you think something changed here?

But I agree that for child frames with their own smaller dimensions
these assignments should be obviously skipped.

martin



reply via email to

[Prev in Thread] Current Thread [Next in Thread]