Re: [scratch/igc] 985247b6bee crash on Linux, KDE, Wayland

[Eval EXEC]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Eval EXEC <execvy@gmail.com>
>> Cc: pipcet@protonmail.com,  gerd.moellmann@gmail.com,  emacs-devel@gnu.org
>> Date: Fri, 06 Sep 2024 02:56:02 +0800
>> 
>> Eli Zaretskii <eliz@gnu.org> writes:
>> 
>> >> From: Eval EXEC <execvy@gmail.com>
>> >> Cc: Eli Zaretskii <eliz@gnu.org>,  Gerd Möllmann
>> >>  <gerd.moellmann@gmail.com>,
>> >>   emacs-devel@gnu.org
>> >> Date: Fri, 06 Sep 2024 01:05:47 +0800
>> >> 
>> >> (gdb) frame 24
>> >> #24 0x0000000000692cd8 in fix_frame (f=0x7fe4284bb270, ss=0x7ffd2708ff28) 
>> >> at /home/exec/Projects/git.savannah.gnu.org/git/emacs/src/igc.c:2068
>> >> 2068            Mouse_HLInfo *hlinfo = MOUSE_HL_INFO (f);
>> >> (gdb) p f
>> >> $1 = (struct frame *) 0x7fe4284bb270
>> >> (gdb) p f->output_data
>> >> $2 = {
>> >>   tty = 0x0,
>> >>   x = 0x0,
>> >>   w32 = 0x0,
>> >>   ns = 0x0,
>> >>   pgtk = 0x0,
>> >>   haiku = 0x0,
>> >>   android = 0x0
>> >> }
>> >
>> > Thanks.  What about
>> >
>> >   (gdb) p f->terminal
>> >
>> > What does that print?
>> 
>> It's:
>> (gdb) p f->terminal
>> $3 = (struct terminal *) 0x0
>
> Thanks, so FRAME_LIVE_P should solve the problem.  I therefore changed
> the test to use FRAME_LIVE_P.

I recompiled commit 95a30325a84 (HEAD -> scratch/igc, origin/scratch/igc)
* src/igc.c (fix_frame): Correct the previous change.

After testing, I believe the issue has been resolved.

Thanks

Eval Exec

--