Re: [elpa] externals/debbugs b8c84dbe4b: Improve needed advice

[Michael Albinus]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> Hi Michael,

Hi Stefan,

>> +(defun debbugs-soap-invoke (operation-name &rest parameters)
>> +  "Invoke the SOAP connection.
>> +OPERATION-NAME and PARAMETERS are as described in `soap-invoke'."
>> +  (debbugs-compat-add-debbugs-advice)
>> +  (prog1
>> +      (apply #'soap-invoke operation-name parameters)
>> +    (debbugs-compat-remove-debbugs-advice)))
>
> I wonder you're doing it this way instead of the "more obvious":
>
>     (defun debbugs-soap-invoke (operation-name &rest parameters)
>       "Invoke the SOAP connection.
>     OPERATION-NAME and PARAMETERS are as described in `soap-invoke'."
>       (let ((url-http-attempt-keepalives nil))
>         (apply #'soap-invoke operation-name parameters)))

Because it doesn't work?

soap-invoke-internal binds url-http-attempt-keepalives to t, which is a
problem in a threaded function. See comment in debbugs-compat.el. See
also bug#73199 for the resulting error.

> - Stefan

Best regards, Michael.